Zxc200611/pocketpy
1
0
Fork 0
mirror of https://github.com/pocketpy/pocketpy synced 2025-10-20 11:30:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

improve dict hash

Browse Source
This commit is contained in:
blueloveTH 2024-12-13 17:13:10 +08:00
parent 5ca7abed5c
commit 3e5d20ab3e
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/public/py_dict.c
View File

@ -183,6 +183,7 @@ static bool Dict__set(Dict* self, py_TValue* key, py_TValue* val) {
py_i64 hash; py_i64 hash;
if(!py_hash(key, &hash)) return false; if(!py_hash(key, &hash)) return false;
int idx = (uint64_t)hash % self->capacity; int idx = (uint64_t)hash % self->capacity;
int bad_hash_count = 0;
for(int i = 0; i < PK_DICT_MAX_COLLISION; i++) { for(int i = 0; i < PK_DICT_MAX_COLLISION; i++) {
int idx2 = self->indices[idx]._[i]; int idx2 = self->indices[idx]._[i];
if(idx2 == -1) { if(idx2 == -1) {
@ -206,9 +207,21 @@ static bool Dict__set(Dict* self, py_TValue* key, py_TValue* val) {
return true; return true;
} }
if(res == -1) return false; // error if(res == -1) return false; // error
// res == 0
bad_hash_count++;
} }
} }
// no empty slot found // no empty slot found
if(bad_hash_count == PK_DICT_MAX_COLLISION) {
// all `PK_DICT_MAX_COLLISION` slots have the same hash but different keys
// we are unable to solve this collision via rehashing
return RuntimeError("dict: %d/%d/%d: maximum collision reached (hash=%i)",
self->entries.length,
self->entries.capacity,
self->capacity,
hash);
}
if(self->capacity >= (uint32_t)self->entries.length * 10) { if(self->capacity >= (uint32_t)self->entries.length * 10) {
return RuntimeError("dict: %d/%d/%d: minimum load factor reached", return RuntimeError("dict: %d/%d/%d: minimum load factor reached",
self->entries.length, self->entries.length,