Compare commits

...

3 Commits

Author SHA1 Message Date
Kanika Kapoor
e076d16892
Merge c048ec9faf4bfe02da004dce69471897933c3617 into 9a57b281e8c5fa622200b4d1fbb53f56066891d9 2026-03-28 20:40:27 +00:00
blueloveTH
9a57b281e8 add := fix #446 2026-03-28 17:53:39 +08:00
Kanika Kapoor
c048ec9faf Fix context manager __exit__ not being called on exception (#395)
Problem: When an exception occurs in a WITH block, __exit__ was not called,
preventing proper cleanup of context managers.

Solution:
1. Wrap WITH block body in try-except structure
2. On normal exit: call __exit__(None, None, None)
3. On exception: call __exit__ with exception info before re-raising

Changes:
- compiler.c: Wrap WITH body in try-except, ensure __exit__ called in both paths
- ceval.c: Update OP_WITH_EXIT to accept three arguments (exc_type, exc_val, exc_tb)
- tests/520_context.py: Add test to verify __exit__ called on exceptions
2025-12-27 01:12:15 +05:30
11 changed files with 171 additions and 13 deletions

View File

@ -3,7 +3,7 @@ output: .retype
url: https://pocketpy.dev
branding:
title: pocketpy
label: v2.1.8
label: v2.1.9
logo: "./static/logo.png"
favicon: "./static/logo.png"
meta:

View File

@ -74,6 +74,7 @@ typedef enum TokenIndex {
TK_GE,
TK_LE,
TK_INVERT,
TK_WALRUS,
/***************/
TK_FALSE,
TK_NONE,
@ -141,6 +142,7 @@ typedef struct Token {
// https://docs.python.org/3/reference/expressions.html#operator-precedence
enum Precedence {
PREC_LOWEST = 0,
PREC_NAMED_EXPR, // :=
PREC_LAMBDA, // lambda
PREC_TERNARY, // ?:
PREC_LOGICAL_OR, // or

View File

@ -35,7 +35,7 @@ A new Flutter FFI plugin project.
s.prepare_command = <<-CMD
rm -rf pocketpy
git clone --branch v2.1.8 --depth 1 https://github.com/pocketpy/pocketpy.git
git clone --branch v2.1.9 --depth 1 https://github.com/pocketpy/pocketpy.git
cd pocketpy
git submodule update --init --recursive --depth 1
bash build_ios_libs.sh

View File

@ -32,7 +32,7 @@ A new Flutter FFI plugin project.
s.prepare_command = <<-CMD
rm -rf pocketpy
git clone --branch v2.1.8 --depth 1 https://github.com/pocketpy/pocketpy.git
git clone --branch v2.1.9 --depth 1 https://github.com/pocketpy/pocketpy.git
cd pocketpy
git submodule update --init --recursive --depth 1
bash build_darwin_libs.sh

View File

@ -1,6 +1,6 @@
name: pocketpy
description: A lightweight Python interpreter for game engines. It supports Android/iOS/Windows/Linux/MacOS.
version: 2.1.8
version: 2.1.9
homepage: https://pocketpy.dev
repository: https://github.com/pocketpy/pocketpy

View File

@ -20,7 +20,7 @@ set(PK_BUILD_SHARED_LIB ON CACHE BOOL "" FORCE)
FetchContent_Declare(
pocketpy
GIT_REPOSITORY https://github.com/pocketpy/pocketpy.git
GIT_TAG v2.1.8
GIT_TAG v2.1.9
)
FetchContent_MakeAvailable(pocketpy)

View File

@ -717,6 +717,36 @@ GroupedExpr* GroupedExpr__new(int line, Expr* child) {
return self;
}
// NamedExpr: walrus operator (x := expr)
typedef struct NamedExpr {
EXPR_COMMON_HEADER
NameExpr* name;
Expr* rhs;
} NamedExpr;
static void NamedExpr__dtor(Expr* self_) {
NamedExpr* self = (NamedExpr*)self_;
vtdelete((Expr*)self->name);
vtdelete(self->rhs);
}
static void NamedExpr__emit_(Expr* self_, Ctx* ctx) {
NamedExpr* self = (NamedExpr*)self_;
vtemit_(self->rhs, ctx); // [value]
Ctx__emit_(ctx, OP_DUP_TOP, BC_NOARG, self->line); // [value, value]
vtemit_store((Expr*)self->name, ctx); // [value]
}
static NamedExpr* NamedExpr__new(int line, NameExpr* name, Expr* rhs) {
const static ExprVt Vt = {.dtor = NamedExpr__dtor, .emit_ = NamedExpr__emit_};
NamedExpr* self = PK_MALLOC(sizeof(NamedExpr));
self->vt = &Vt;
self->line = line;
self->name = name;
self->rhs = rhs;
return self;
}
typedef struct BinaryExpr {
EXPR_COMMON_HEADER
Expr* lhs;
@ -1680,6 +1710,22 @@ static Error* exprAnd(Compiler* self) {
return NULL;
}
static Error* exprWalrus(Compiler* self) {
Error* err;
int line = prev()->line;
// LHS is on the stack; verify it's a simple name
Expr* lhs = Ctx__s_top(ctx());
if(!lhs->vt->is_name) {
return SyntaxError(self, "':=' target must be a simple name");
}
check(parse_expression(self, PREC_NAMED_EXPR + 1, false));
Expr* rhs = Ctx__s_popx(ctx());
NameExpr* name = (NameExpr*)Ctx__s_popx(ctx());
NamedExpr* e = NamedExpr__new(line, name, rhs);
Ctx__s_push(ctx(), (Expr*)e);
return NULL;
}
static Error* exprTernary(Compiler* self) {
// [true_expr]
Error* err;
@ -2801,6 +2847,8 @@ static Error* compile_stmt(Compiler* self) {
case TK_WITH: {
check(EXPR(self)); // [ <expr> ]
Ctx__s_emit_top(ctx());
// Save context manager for later __exit__ call
Ctx__emit_(ctx(), OP_DUP_TOP, BC_NOARG, prev()->line);
Ctx__enter_block(ctx(), CodeBlockType_WITH);
NameExpr* as_name = NULL;
if(match(TK_AS)) {
@ -2809,17 +2857,33 @@ static Error* compile_stmt(Compiler* self) {
as_name = NameExpr__new(prev()->line, name, name_scope(self));
}
Ctx__emit_(ctx(), OP_WITH_ENTER, BC_NOARG, prev()->line);
// [ <expr> <expr>.__enter__() ]
if(as_name) {
bool ok = vtemit_store((Expr*)as_name, ctx());
vtdelete((Expr*)as_name);
if(!ok) return SyntaxError(self, "invalid syntax");
} else {
// discard `__enter__()`'s return value
Ctx__emit_(ctx(), OP_POP_TOP, BC_NOARG, BC_KEEPLINE);
}
// Wrap body in try-except to ensure __exit__ is called even on exception
Ctx__enter_block(ctx(), CodeBlockType_TRY);
Ctx__emit_(ctx(), OP_BEGIN_TRY, BC_NOARG, prev()->line);
check(compile_block_body(self));
Ctx__emit_(ctx(), OP_END_TRY, BC_NOARG, BC_KEEPLINE);
// Normal exit: call __exit__(None, None, None)
Ctx__emit_(ctx(), OP_LOAD_NONE, BC_NOARG, prev()->line);
Ctx__emit_(ctx(), OP_LOAD_NONE, BC_NOARG, prev()->line);
Ctx__emit_(ctx(), OP_LOAD_NONE, BC_NOARG, prev()->line);
Ctx__emit_(ctx(), OP_WITH_EXIT, BC_NOARG, prev()->line);
int jump_patch = Ctx__emit_(ctx(), OP_JUMP_FORWARD, BC_NOARG, BC_KEEPLINE);
Ctx__exit_block(ctx());
// Exception handler: call __exit__ with exception info, then re-raise
Ctx__emit_(ctx(), OP_PUSH_EXCEPTION, BC_NOARG, BC_KEEPLINE);
Ctx__emit_(ctx(), OP_LOAD_NONE, BC_NOARG, BC_KEEPLINE); // exc_type
Ctx__emit_(ctx(), OP_ROT_TWO, BC_NOARG, BC_KEEPLINE); // reorder: [cm, None, exc]
Ctx__emit_(ctx(), OP_LOAD_NONE, BC_NOARG, BC_KEEPLINE); // exc_tb
Ctx__emit_(ctx(), OP_WITH_EXIT, BC_NOARG, prev()->line);
Ctx__emit_(ctx(), OP_RE_RAISE, BC_NOARG, BC_KEEPLINE);
Ctx__patch_jump(ctx(), jump_patch);
Ctx__exit_block(ctx());
} break;
/*************************************************/
@ -2977,6 +3041,7 @@ const static PrattRule rules[TK__COUNT__] = {
[TK_AND_KW ] = { NULL, exprAnd, PREC_LOGICAL_AND },
[TK_OR_KW] = { NULL, exprOr, PREC_LOGICAL_OR },
[TK_NOT_KW] = { exprNot, NULL, PREC_LOGICAL_NOT },
[TK_WALRUS] = { NULL, exprWalrus, PREC_NAMED_EXPR },
[TK_TRUE] = { exprLiteral0 },
[TK_FALSE] = { exprLiteral0 },
[TK_NONE] = { exprLiteral0 },

View File

@ -469,7 +469,11 @@ static Error* lex_one_token(Lexer* self, bool* eof, bool is_fstring) {
// BUG: f"{stack[2:]}"
return eat_fstring_spec(self, eof);
}
add_token(self, TK_COLON);
if(matchchar(self, '=')) {
add_token(self, TK_WALRUS);
} else {
add_token(self, TK_COLON);
}
return NULL;
}
case ';': add_token(self, TK_SEMICOLON); return NULL;
@ -694,6 +698,7 @@ const char* TokenSymbols[] = {
">=",
"<=",
"~",
":=",
/** KW_BEGIN **/
// NOTE: These keywords should be sorted in ascending order!!
"False",

View File

@ -1122,14 +1122,35 @@ __NEXT_STEP:
DISPATCH();
}
case OP_WITH_EXIT: {
// [expr]
py_push(TOP());
// Stack: [cm, exc_type, exc_val, exc_tb]
// Call cm.__exit__(exc_type, exc_val, exc_tb)
py_Ref exc_tb = TOP();
py_Ref exc_val = SECOND();
py_Ref exc_type = THIRD();
py_Ref cm = FOURTH();
// Save all values from stack
py_TValue saved_cm = *cm;
py_TValue saved_exc_type = *exc_type;
py_TValue saved_exc_val = *exc_val;
py_TValue saved_exc_tb = *exc_tb;
self->stack.sp -= 4;
// Push cm and get __exit__ method
py_push(&saved_cm);
if(!py_pushmethod(__exit__)) {
TypeError("'%t' object does not support the context manager protocol", TOP()->type);
TypeError("'%t' object does not support the context manager protocol", saved_cm.type);
goto __ERROR;
}
if(!py_vectorcall(0, 0)) goto __ERROR;
POP();
// Push arguments: exc_type, exc_val, exc_tb
PUSH(&saved_exc_type);
PUSH(&saved_exc_val);
PUSH(&saved_exc_tb);
// Call __exit__(exc_type, exc_val, exc_tb)
if(!py_vectorcall(3, 0)) goto __ERROR;
py_pop(); // discard return value
DISPATCH();
}
///////////

View File

@ -27,4 +27,29 @@ assert path == ['enter', 'in', 'exit']
path.clear()
# Test that __exit__ is called even when an exception occurs
class B:
def __init__(self):
self.path = []
def __enter__(self):
path.append('enter')
return self
def __exit__(self, exc_type, exc_val, exc_tb):
path.append('exit')
if exc_type is not None:
path.append('exception')
return False # propagate exception
try:
with B():
path.append('before_raise')
raise ValueError('test')
path.append('after_raise') # should not be reached
except ValueError:
pass
assert path == ['enter', 'before_raise', 'exit', 'exception'], f"Expected ['enter', 'before_raise', 'exit', 'exception'], got {path}"

40
tests/90_walrus.py Normal file
View File

@ -0,0 +1,40 @@
# Test walrus operator (:=)
# Basic usage in if statement
x = [1, 2, 3, 4, 5]
if (n := len(x)) > 3:
assert n == 5
# Usage in while loop
data = [1, 2, 3, 0, 4, 5]
results = []
i = 0
while (val := data[i]) != 0:
results.append(val)
i += 1
assert results == [1, 2, 3]
# Usage in list comprehension filter
values = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
even_squares = [y for x in values if (y := x * x) % 2 == 0]
assert even_squares == [4, 16, 36, 64, 100]
# Walrus in expression context
a = 10
b = (a := a + 5) * 2
assert a == 15
assert b == 30
# Nested parenthesized walrus
result = (x := (y := 3) + 1)
assert x == 4
assert y == 3
# Test function
def test_walrus_in_function():
result = (x := (y := 3) + 1)
assert x == 4
assert y == 3
assert result == 4
test_walrus_in_function()